Windows build support. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mortacious merged 1 commit into mortacious:master from syoyo:windows-support

Apr 10, 2022

Contributor

syoyo commented Apr 10, 2022

Thank you for great library!

This PR supports building python-optix on Windows.

I have confirmed every scripts in examples works well on Windows.

Changes are:

Define NOMINMAX for MSVC(otherwise comilation fails for std::max used in OptiX header)
Link with advapi32(OptiX uses some Windows Registry API)

Build environment

Windows11 64bit
Conda python 3.8
MSVC(VS2019)


          Windows build support.

d007060

mortacious merged commit 23975be into mortacious:master

Owner

mortacious commented Apr 10, 2022

Hey, tanks for the contribution! Really great to get the Windows support up and running! I will merge and make a new Release ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet